Open
Conversation
fmeum
requested review from
armandomontanez,
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
With the exception of special module map names, all of them are effectively labels. This commit ensures that they are retained as `Label`s, not label string and thus: * memory usage is reduced for module maps from external repos, whose module map name previously resulted in a newly retained string; * module map names now use properly formatted external repo labels as names, which makes it more obvious what they are; * the roundtrip in header module compilation flows is avoided. This actually fixes a bug where the missing `@@` prefix for label strings resulted in incorrect or even failing `Label` calls due to main repo labels being resolved relative to the rules_cc repo and external repo labels failing the validation of the `Label` constructor.
armandomontanez
added
type: bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the exception of special module map names, all of them are effectively labels. This commit ensures that they are retained as
Labels, not label string and thus:@@prefix for label strings resulted in incorrect or even failingLabelcalls due to main repo labels being resolved relative to the rules_cc repo and external repo labels failing the validation of theLabelconstructor.