Updates android builds to always use 16KB memory pages#121
Open
SvenSchindler wants to merge 1 commit intobazelbuild:mainfrom
Open
Updates android builds to always use 16KB memory pages#121SvenSchindler wants to merge 1 commit intobazelbuild:mainfrom
SvenSchindler wants to merge 1 commit intobazelbuild:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
SvenSchindler
commented
Feb 5, 2026
| flags = ["-Wl,--fix-cortex-a8", "-march=armv7-a"], | ||
| features = ["crosstool_cpu_arm"], | ||
| ), | ||
| flag_set( |
Author
There was a problem hiding this comment.
I don't think we need to keep this flag set anymore but please correct me if I'm wrong 🙏 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Android expects apps to support 16KB memory page alignments, otherwise it'll complain. This PR updates the linking flags to default to 16KB memory pages. For more details see https://developer.android.com/guide/practices/page-sizes.