android_application: set the default _merge_manifests attribute corre…#516
Open
06393993 wants to merge 1 commit into
Open
android_application: set the default _merge_manifests attribute corre…#51606393993 wants to merge 1 commit into
06393993 wants to merge 1 commit into
Conversation
…ctly merge_feature_manifests.par is a zip file, and is not executable. Just use the original `py_binary` target. And since the `py_binary` target has multiple files, we remove `allow_single_file = True`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ctly
merge_feature_manifests.par is a zip file, and is not executable. Just use the original
py_binarytarget. And since thepy_binarytarget has multiple files, we removeallow_single_file = True.We can keep the
merge_feature_manifests.partarget name viaaliasif that makes the life to sync between google3 and the OSS version easier.