android toolchain: add the missing xmllint tool#514
Open
06393993 wants to merge 1 commit into
Open
Conversation
ted-xie
reviewed
Jun 3, 2026
| name = "gen_xmllint", | ||
| outs = ["xmllint.sh"], | ||
| cmd = """cat > $@ <<EOF | ||
| xmllint \\$$@ |
Contributor
There was a problem hiding this comment.
There is no guarantee that xmllint is installed on all user machines, so this has to come from some kind of repo rule or compatibility shim binary.
Contributor
There was a problem hiding this comment.
Did some quick research. libxml2 is already on the BCR: https://registry.bazel.build/modules/libxml2
And xmllint can be depended on via @libxml2//:xmllint.
Contributor
Author
There was a problem hiding this comment.
For bzlmod, added libxml2 from BCR and use @libxml2//:xmllint.
For WORKSPACE, added http_archive invocation for libxml2, and checked in the BCR overlay files. PTAL, thanks.
06393993
force-pushed
the
fix_xmllint
branch
2 times, most recently
from
cbb864b to
e1cc387
Compare
It's used by the `android_feature_module` rule defined at `rules/android_application/android_feature_module_rule.bzl` to check if the manifest file is valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's used by the
android_feature_modulerule defined atrules/android_application/android_feature_module_rule.bzlto check if the manifest file is valid.