Repository navigation
fix: quote paths in stage1_bootstrap_template.sh - #4386
Merged
Merged
Conversation
Unquoted path expansions in stage1_bootstrap_template.sh fail with word splitting when the executable symlink path, runfiles root directory, or RULES_PYTHON_EXTRACT_ROOT contains spaces (for example, in Bazel's bazel_determinism_test). Quote $0, $stub_filename, $RUNFILES_DIR, $PYTHON_BINARY, $PYTHON_BINARY_ACTUAL, $RULES_PYTHON_EXTRACT_ROOT, $python_exe, and $venv_site_packages when resolving runfiles and creating runtime venvs, and extend the bootstrap runfiles and runtime venv tests to exercise paths with spaces.
Contributor
Author
|
AI Disclosure: This PR was prepared with an AI coding assistant under human direction ( |
rickeylev
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unquoted path expansions in
stage1_bootstrap_template.shfail with word splitting when the executable symlink path, runfiles root directory, orRULES_PYTHON_EXTRACT_ROOTcontains spaces (for example, in Bazel'sbazel_determinism_test).Quote
$0,$stub_filename,$RUNFILES_DIR,$PYTHON_BINARY,$PYTHON_BINARY_ACTUAL,$RULES_PYTHON_EXTRACT_ROOT,$python_exe, and$venv_site_packageswhen resolving runfiles and creating runtime venvs, and extend the bootstrap runfiles and runtime venv tests to exercise paths with spaces.