Repository navigation
fix(pypi): generate namespace package initializers without a shell - #4385
Merged
Merged
Conversation
Wheel namespace packages use an __init__.py file generated from a checked-in template. Skylib's copy_file invokes cp through a shell on Unix, which fails on execution platforms that provide neither program. Use expand_template with no substitutions. This produces a regular file with the same bytes from the same template, without spawning a process on the execution platform. The namespace initializer generator was introduced in bazel-contrib@dce512024.
Contributor
Author
|
Codex prepared this change on behalf of @tamird. Tamir chose the approach This is an automatically generated agent comment. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the change removing shell and cp requirements from namespace initializer generation.
No open issues 🎉
What changed in this PR
This PR removes the shell and cp requirement from wheel namespace initializer generation, allowing it to work on execution platforms without those programs.
Changes:
- Replace Skylib’s
copy_filewithexpand_templateusing no substitutions to preserve template contents. - Update the rule dependency and unit-test expectations.
- Add a release note describing the fix.
| File | Description |
|---|---|
| tests/pypi/namespace_pkgs/namespace_pkgs_tests.bzl | Update mocked generator calls and expected template arguments. |
| python/private/pypi/namespace_pkgs.bzl | Generate namespace initializers with expand_template. |
| python/private/pypi/BUILD.bazel | Switch the dependency to Skylib’s expand_template. |
| news/wheel-namespace-initializers.fixed.md | Document removal of the shell and cp requirement. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wheel namespace packages use an init.py file generated from a
checked-in template. Skylib's copy_file invokes cp through a shell on
Unix, which fails on execution platforms that provide neither program.
Use expand_template with no substitutions. This produces a regular
file with the same bytes from the same template, without spawning a
process on the execution platform.
The namespace initializer generator was introduced in
dce512024.