Repository navigation
fix: tolerate absolute interpreter paths for lock update - #4384
Merged
Merged
Conversation
Since commit 2d39a20 (feat(uv): add --directory support for locking (bazel-contrib#4029), 2026-09-02), the `lock` macro defaults the `directory` to the package name, and attempts to resolve the path to the Python interpreter via relative path after `uv` changes into that directory. This is fine for hermetic Python, but it doesn't respect the case that `interpreter_path` is absolute. If we have an absolute path to an interpreter, it doesn't need to involve `--directory`, so avoid the prefix altogether.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #4029, the
lockmacro defaults thedirectoryto the package name, and attempts to resolve the path to the Python interpreter via relative path afteruvchanges into that directory. This is fine for hermetic Python, but it doesn't respect the case thatinterpreter_pathis absolute.If we have an absolute path to an interpreter, it doesn't need to involve
--directory, so avoid the prefix altogether.