Repository navigation
fix: Use purl.bzl for a better api, add module package_metadata #4276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
b6111d1
da86260
656063a
8cac3e5
305de36
6e685d3
2dc9eee
e6b274c
56995fe
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,17 @@ workspace(name = "rules_python") | |
| # Everything below this line is used only for developing rules_python. Users | ||
| # should not copy it to their WORKSPACE. | ||
|
|
||
| # Loaded by Starlark files (e.g. purl.bzl) that the loads below pull in, so it | ||
| # must be defined before them. | ||
|
Comment on lines
+20
to
+21
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we still need this comment and change?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, otherwise it still breaks WORKSPACE based tests because of the wrong order of loads
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If that is the case it may still be a breaking change, let's bring back the other change that got reverted and just mark this as breaking for workspace users and add a snippet for WORKSPACE user that they would need to unbreak their setups. WORKSPACE setup is best effort afterall. |
||
| load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") | ||
|
|
||
| http_archive( | ||
| name = "package_metadata", | ||
| sha256 = "755bd6c8a3751982e2555d96c913ec070954ca9d01f935563392255da4ebad72", | ||
| strip_prefix = "package_metadata-0.0.13/metadata", | ||
| url = "https://github.com/bazel-contrib/supply-chain/releases/download/package_metadata-0.0.13/package_metadata-0.0.13.tar.gz", | ||
| ) | ||
|
|
||
| # Workaround for Bazel 9 duplicate name issue in Gazelle. | ||
| load("//:workspace_bazel9.bzl", "bazel_9_workaround") | ||
|
|
||
|
|
@@ -85,8 +96,6 @@ load("@uv_manifest//:dist_manifest.bzl", "uv_register_toolchains") | |
|
|
||
| uv_register_toolchains(name = "uv") | ||
|
|
||
| load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") | ||
|
|
||
| # Used for Bazel CI | ||
| http_archive( | ||
| name = "bazelci_rules", | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.