chore: use bazel 9 by default#3662
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request upgrades the project's Bazel dependency to version 9.x across the main configuration and its bzlmod examples. This update ensures that the project leverages the latest features, performance improvements, and bug fixes provided by Bazel 9, enhancing the build system's efficiency and reliability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the default Bazel version to 9.x. However, a related constant BAZEL_VERSION in version.bzl was not updated, which will cause an inconsistency in the repository. I've added a specific comment about this necessary change.
| @@ -1 +1 @@ | |||
| 8.x | |||
| 9.x | |||
|
I've gone and remove the assert_bazelversion test. I don't see the value in test that validates the .bazelversion file against the currently running bazel. We have a bunch of cases where they wouldn't be the same (I.e. two thirds of our CI jobs) |
Updates the project bazel version and bzlmod examples to use Bazel 9
Along the way, upgrade rules_go to 0.60.0; this is a dev-only dependency. This is needed
because Bazel 9 removed CcInfo, and earlier rules_go versions refer to the builtin symbol.
Also remove the test to check the bazel version. It doesn't do much useful.