chore (py_internal): Remove roundtrip of putting py_internal in the config repo

[shayanhoshyari]

I was reading on py_internal and found this opportunity for simplification.

When there was support for Bazel < 7 py_internal was in @rules_python_internal, because it had to be set to None depending on Bazel version.

#3282 removed Bazel < 7 support shims, and made py_internal not depend on Bazel version. So now there no need to put it in @rules_python_internal.

[gemini-code-assist]

Summary of Changes

Hello @shayanhoshyari, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the loading of the py_internal module by eliminating an indirect dependency that was previously required for compatibility with older Bazel versions. With the removal of Bazel < 7 support, the py_internal module can now be loaded directly, simplifying the build configuration and reducing unnecessary complexity in the internal configuration repository.

Highlights

• Simplification of py_internal loading: The pull request removes an unnecessary roundtrip mechanism for loading py_internal by directly referencing it within the main repository.
• Removal of Bazel < 7 compatibility shim: This simplification was made possible by the prior removal of support for Bazel versions older than 7, which previously necessitated the complex loading mechanism for py_internal.
• Refactored internal_config_repo.bzl: The internal_config_repo.bzl file has been cleaned up by removing the _PY_INTERNAL_SHIM and related logic that created a py_internal.bzl file in the generated config repository.
• Updated dependencies and visibility: Dependency references for py_internal_bzl and visibility settings for py_internal_renamed_bzl have been updated to reflect the direct loading approach.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request simplifies the handling of the py_internal object by removing legacy compatibility logic for Bazel versions older than 7. The changes are clean, correct, and make the build configuration easier to follow. I have one suggestion to improve a comment for better clarity on the visibility workaround for py_internal.

[shayanhoshyari]

cc: @aignas since you did the original simplification (#3282)

[aignas]

Is there any benefit in runtime performance, etc, or is it just a cleanup of the code? I am not sure I understand the implications by just reading the comments.

[shayanhoshyari]

Is there any benefit in runtime performance, etc, or is it just a cleanup of the code? I am not sure I understand the implications by just reading the comments.

Just cleanup the code.

Performance and code behavior should remain the same.

I was trying to wrap my head around why py_internal is going through so many loops. With this change next person reading the code hopefully does not have to.

---

Before

flowchart TB
A["//tools/build_defs/python/private:py_internal_renamed.bzl<br>py_internal_renamed"]
B["@rules_python_internal//:py_internal.bzl<br>py_internal_impl"]
C["@rules_python//private:py_internal.bzl<br>py_internal"]

A --> B --> C

Loading

Now

flowchart TB
A2["//tools/build_defs/python/private:py_internal_renamed.bzl<br>py_internal_renamed"]
C2["@rules_python//private:py_internal.bzl<br>py_internal"]

A2 --> C2

Loading

rules_python_internal//:py_internal.bzl usage was only needed for Bazel 6 or earlier, since for those py_internal was not defined, and it was set to None for them depending on Bazel version, like when <= supported. But now that it is unconditionally available, no need for this.

[aignas]

Thanks!