-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add packaging package
#596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughA single runtime dependency Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
23-23: Use a more conservative version constraint for better compatibility.The
packaging>=25.0constraint is unnecessarily restrictive. Since the code only usespackaging.version.parse()— a stable API available since v14.1 (2014) — a more conservative constraint like>=20.0would provide broader compatibility and reduce potential dependency conflicts with other packages that specify lower version bounds.Consider changing to:
- "packaging>=25.0", + "packaging>=20.0",
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #596 +/- ##
=======================================
Coverage 97.89% 97.89%
=======================================
Files 10 10
Lines 1185 1185
=======================================
Hits 1160 1160
Misses 25 25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the contribution! |
The problem:
packagingis imported inacquisition.pybut not defined inpyproject.toml. This leads to aModuleNotFoundErrorwhen trying to importbayes_optafter installing the requirements.Solution: This adds
packagingto the project dependencies.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.