Tokenizer: Parse operators one at a time#13
Tokenizer: Parse operators one at a time#13ChristianStadelmann wants to merge 1 commit intobastibe:masterfrom
Conversation
Prior to this change, any line ending with `[punctuation + '...']`, for example `||...`, would cause the tokenizer to fail. Fixes bastibe#9
|
This is an alternative to #12. |
|
I know that you don't like the |
Don't get me wrong, I very much endorse Either way, we could also write a unit test case to cover the documented bug and it's fix. Never done that in Matlab and I suppose only very few cases are only implemented there so far? Therefore, I don' know if that is really required. I suppose it is on @bastibe to decide if and when #12 or #13 gets accepted?! |
|
I think I generally prefer #12, as I find it a bit easier to follow. However, if you feel #13 is actually a better implementation, I'd go with your suggestions. Honestly, it has been a long while since I last worked with this code, and Matlab in general. And any improvement of the unit tests would be greatly appreciated, of course! |
Prior to this change, any line ending with
[punctuation + '...'], forexample
||..., would cause the tokenizer to fail.Fixes #9