fix(mcp): gate ChatGPT compatibility tools by clientInfo#1035
Merged
Conversation
Signed-off-by: phernandez <paul@basicmachines.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ChatGPT advertises itself as
openai-mcpinclientInfo, and the OpenAI MCP directory expects the compatibilitysearchandfetchtools for deep research/company knowledge flows. Other MCP clients can use the native Basic Memory tools, so the ChatGPT-only shims should not run for Codex, Claude, or generic clients.What Changed
initialize.clientInfoin FastMCP session state.searchandfetchtools onopenai-mcp/openai-mcp/....search_notesandread_note.openai-mcp, with default-client rejection coverage.Implementation Details
The gate is deliberately based on MCP session state from
initialize, not on a separate endpoint or auth route. The client match accepts the exact dashboard labels we have seen (openai-mcpandopenai-mcp/1.0.0) in eithernameortitle; missing or non-OpenAI labels fail closed.Testing
uv run pytest tests/mcp/test_client_info.py tests/mcp/tools/test_chatgpt_tools.py test-int/mcp/test_chatgpt_tools_integration.py -qpassed.just fast-checkpassed lint, format, typecheck, and the selected MCP tests; it failed only ontest-int/semantic/test_semantic_quality.py::test_semantic_quality[asyncio-postgres-openai]because the live OpenAI embeddings request returned429 insufficient_quota.Risks / Follow-ups
The cloud MCP telemetry middleware still needs to preserve recovered
clientInfoacross stateless HTTP tool calls; that is handled in the paired Basic Memory Cloud PR.