Repository navigation
ci: migrate macOS validation to macos-15 runner - #578
Merged
codeforester merged 2 commits intoOct 17, 2026
Merged
codeforester merged 2 commits into
codeforester merged 2 commits into
Conversation
codeforester
force-pushed
the
ci/577-20261017-migrate-validation-matrix-off-retired-macos-14-runner
branch
from
October 16, 2026 18:53
de3025f to
5f5a7c4
Compare
codeforester
commented
Oct 17, 2026
codeforester
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review: LGTM, no blocking issues. Reviewed all 5 files at 5f5a7c4.
- The runner is selected in one place (the
tests.ymlmatrix, consumed viaruns-on: ${{ matrix.os }}); no other workflow or script namesmacos-14. The two remaining mentions (docs/release-process.md--platform macos-14andtests/release-bom-row.bats) are the logical release-platform id, which the issue says to keep. - The job name changes from
Validate (macos-14)toValidate (macos-15), but the ruleset's required checks (base/issue-branch-policy,Product validation,Quality contract) do not name the matrix leg, so no required check is stranded. - Hosted
Validate (macos-15),Validate (ubuntu-24.04), the Bash 4.2.53 / 4.4.23 / 5.0.18 / 5.2.37 compatibility jobs, the release gates and the Beacon downstream smoke are all green, so the Bash 4.2 assertions are intact. - Historical record handling is right: the v2.2.0 run note says explicitly that it used the macOS 14 image.
Non-blocking
- The PR body says two existing
validate-drivershim tests fail locally before the migration-specific checks. Hosted validation is green, so this looks environmental, but please say whether they fail the same way onmain(or file an issue) so the local failure is not left ambiguous in the record. - One wording point, inline on
support-matrix.md.
| | --- | --- | --- | | ||
| | Bash | 4.2.53 minimum; representative 4.4.23 and 5.0.18/5.2.37; current 5.x | Pinned networkless Bash containers, current runner validation, `tests/compatibility-matrix.sh`, deterministic property, artifact, and concurrency contracts | | ||
| | macOS | Pinned GitHub-hosted macOS 14 with Homebrew Bash; system Bash 3.2 is rejected with remediation | macOS validation and unsupported-system-Bash smoke | | ||
| | macOS | macOS 14 compatibility exercised on the pinned GitHub-hosted macOS 15 runner with Homebrew Bash; system Bash 3.2 is rejected with remediation | macOS validation and unsupported-system-Bash smoke | |
Collaborator
Author
There was a problem hiding this comment.
A macOS 15 run does not exercise macOS 14-specific behaviour, so "macOS 14 compatibility exercised on the pinned … macOS 15 runner" slightly over-claims in an Evidence table. The issue asks for this phrasing, so it is fine to keep, but something like "macOS 14 is the supported floor; hosted validation runs on the pinned macOS 15 runner (no macOS 14 runner available)" is more precise. Same point as basefoundry/base#2605 (README L591-592), so worth settling once across the train.
codeforester
deleted the
ci/577-20261017-migrate-validation-matrix-off-retired-macos-14-runner
branch
October 17, 2026 14:34
42 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #577.
Part of the coordinated train anchored by basefoundry/base#2604.
Changes:
macos-15.Local validation:
git diff --checkpassed.tests/validate.shwas exercised; two existing validate-driver shim tests fail locally before the migration-specific checks, so hosted validation is required for final acceptance.