Fix accent/dead key composition in House MD editor#411
Draft
arturo-ojeda wants to merge 1 commit intobasecamp:mainfrom
Draft
Fix accent/dead key composition in House MD editor#411arturo-ojeda wants to merge 1 commit intobasecamp:mainfrom
arturo-ojeda wants to merge 1 commit intobasecamp:mainfrom
Conversation
The editor's beforeinput handler calls preventDefault() on all events, including insertCompositionText. This breaks the browser's internal composition tracking, causing getTargetRanges() to return stale ranges on subsequent composition events. Dead key accents (e.g. Option+E then 'a' for á) produce broken output like ´á instead of á. Fix: track composition start position and length internally so insertCompositionText events use the correct replacement range regardless of the browser's stale target ranges. Fixes basecamp#410 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The editor's beforeinput handler calls preventDefault() on all events, including insertCompositionText. This breaks the browser's internal composition tracking, causing getTargetRanges() to return stale ranges on subsequent composition events. Dead key accents (e.g. Option+E then 'a' for á) produce broken output like ´á instead of á.
Fix: track composition start position and length internally so insertCompositionText events use the correct replacement range regardless of the browser's stale target ranges.
Fixes #410