Detect silent DataTransfer write failures - #1340
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes writable DataTransfer detection by verifying that probe data persists after writing.
Changes:
- Corrects the source helper’s comparison.
- Rebuilds the Action Text asset with the same fix.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/trix/core/helpers/events.js |
Correctly detects silently rejected writes. |
action_text-trix/app/assets/javascripts/trix.js |
Updates the generated asset. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the write verification in
dataTransferIsWritable.The current
!getData(...) === valueexpression applies boolean negation before strict equality, so it never detects a setter that silently refuses to persist the probe value. Comparing the retrieved value directly makes the helper returnfalsefor both throwing and non-persisting implementations.The generated Action Text asset is rebuilt with the same one-line change.
Verification
trueto writable=false; normal and missing-setter cases remain unchangedNo public API or dependency change.