Fix all-day calendar event edits - #363
Open
robzolkos wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Pins the HEY SDK release that fixes all-day event updates and adds regression coverage for omitted clock-time fields.
Changes:
- Upgrades
hey-sdk/goto v0.28.1. - Tests all-day event edit payloads.
- Synchronizes MCP model provenance.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
go.mod |
Pins HEY SDK v0.28.1. |
go.sum |
Updates SDK checksums. |
internal/cmd/events_test.go |
Adds all-day edit regression coverage. |
internal/mcpserver/model/PROVENANCE.json |
Records the matching SDK tag and commit. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/basecamp/hey-sdk/goto v0.28.1Fixes #362.
Validation
starts_at_time=:00andends_at_time=:00GOWORK=off make checkSummary by cubic
Fixes all-day calendar event edits by upgrading
@basecamp/hey-sdk/goto v0.28.1, which stops the edit request from sending thestarts_at_timeandends_at_timefields as:00for all-day events. Adds a regression test that verifies those fields are omitted.github.com/basecamp/hey-sdk/gofrom v0.28.0 to v0.28.1 and syncs the vendored SDK model provenance and Nix vendor hash.Written for commit 214f8e2. Summary will update on new commits.