Skip to content

Fix all-day calendar event edits - #363

Open
robzolkos wants to merge 2 commits into
mainfrom
fix/all-day-event-edit
Open

Fix all-day calendar event edits#363
robzolkos wants to merge 2 commits into
mainfrom
fix/all-day-event-edit

Conversation

@robzolkos

@robzolkos robzolkos commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • bump github.com/basecamp/hey-sdk/go to v0.28.1
  • verify all-day event edits omit both clock-time fields
  • sync the vendored SDK model provenance with the pinned release

Fixes #362.

Validation

  • Confirmed the new regression test fails against SDK v0.28.0 with starts_at_time=:00 and ends_at_time=:00
  • Confirmed the test passes against SDK v0.28.1
  • GOWORK=off make check
  • Live HEY smoke test with this branch: create all-day event, edit its title, and delete it successfully

Summary by cubic

Fixes all-day calendar event edits by upgrading @basecamp/hey-sdk/go to v0.28.1, which stops the edit request from sending the starts_at_time and ends_at_time fields as :00 for all-day events. Adds a regression test that verifies those fields are omitted.

  • Bumps github.com/basecamp/hey-sdk/go from v0.28.0 to v0.28.1 and syncs the vendored SDK model provenance and Nix vendor hash.
  • Adds a test confirming all-day event edits send calendar dates without clock times.

Written for commit 214f8e2. Summary will update on new commits.

Review in cubic

@robzolkos
robzolkos requested a review from a team as a code owner August 29, 2026 17:12
Copilot AI balanced review requested due to automatic review settings August 29, 2026 17:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the HEY SDK release that fixes all-day event updates and adds regression coverage for omitted clock-time fields.

Changes:

  • Upgrades hey-sdk/go to v0.28.1.
  • Tests all-day event edit payloads.
  • Synchronizes MCP model provenance.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
go.mod Pins HEY SDK v0.28.1.
go.sum Updates SDK checksums.
internal/cmd/events_test.go Adds all-day edit regression coverage.
internal/mcpserver/model/PROVENANCE.json Records the matching SDK tag and commit.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTTP 400 saving all-day calendar events in TUI (hey-sdk bug)

2 participants