Select threads with x as well as space - #359
Open
jwahdatehagh wants to merge 1 commit into
Open
Conversation
The HEY desktop app selects a thread in the list with x; the TUI only answered to space. x now toggles the selection in the box list and on the Previously Seen screen, matching the app. x was the cover peek's key, so the peek moves to z — the cover hints in the section headers and the help bar move with it.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds x as a thread-selection shortcut and moves cover peeking to z.
Changes:
- Supports
xselection in mail and Previously Seen lists. - Updates cover controls and hints from
xtoz. - Adds tests for selection and cover behavior.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
internal/tui/mail.go |
Updates key routing and help bindings. |
internal/tui/mail_test.go |
Tests x selection and z cover toggling. |
internal/tui/covers_test.go |
Updates expected cover hints. |
internal/tui/content.go |
Changes rendered cover hints to z. |
internal/tui/calendar_views.go |
Updates a related comment. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| case "c": | ||
| return v.startCompose() | ||
| case " ", "space": | ||
| case " ", "space", "x": |
| case "n", "N": | ||
| return v.startCollectionPicker() | ||
| case "x": | ||
| case "z": |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HEY desktop app toggles a thread's selection with
x; the TUI only answered tospace. For parity,xnow toggles the selection too, in the box list and on the Previously Seen screen. The help bar shows the pair asspace/x select.xwas previously the cover peek's key on a covered Imbox, so the peek moves toz: the section-header hints ("z to peek" / "z to cover") and the help bar move with it.Tests cover
xselecting (and not lifting the cover) in both lists, and the cover peek tests now exercisez.make checkpasses.Summary by cubic
Makes
xtoggle a thread's selection in the box list and Previously Seen screen, matching the HEY desktop app;spacestill works. The cover peek key moves fromxtoz, with the help bar and section-header hints updated accordingly.xtoggles selection without affecting the cover state.xselection in both lists andzcover peeking.Written for commit d06801e. Summary will update on new commits.