Update docker-deployment.md with additional info for SSL/TLS setup#2914
Open
GershN wants to merge 3 commits into
Open
Update docker-deployment.md with additional info for SSL/TLS setup#2914GershN wants to merge 3 commits into
GershN wants to merge 3 commits into
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Docker deployment documentation to better explain SSL/TLS configuration and required network access.
Changes:
- Clarifies that ports 80/443 must be reachable from the internet when using SSL.
- Adds a brief note describing automatic TLS via the
TLS_DOMAINsetting and the underlying tooling.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| docker run --publish 80:80 --env DISABLE_SSL=true ... | ||
| ``` | ||
|
|
||
| The TLS_domain setting uses Thunder and LetsEncrypt to automatically provide SSL/TLS access (https://github.com/basecamp/thruster) |
capitalise TLS_DOMAIN
typo Thruster not Thunder.
| If you want the Fizzy container to handle its own SSL automatically, you just need to specify the domain name that you're running it on. | ||
| You can do that with the `TLS_DOMAIN` environment variable. | ||
| Note that if you're using SSL, you'll want to allow traffic on ports 80 and 443. | ||
| Note that if you're using SSL, you'll want to allow traffic on ports 80 and 443 and allow access from the internet. |
| docker run --publish 80:80 --env DISABLE_SSL=true ... | ||
| ``` | ||
|
|
||
| The TLS_DOMAIN setting uses Thruster and LetsEncrypt to automatically provide SSL/TLS access (https://github.com/basecamp/thruster) |
| docker run --publish 80:80 --env DISABLE_SSL=true ... | ||
| ``` | ||
|
|
||
| The TLS_DOMAIN setting uses Thruster and LetsEncrypt to automatically provide SSL/TLS access (https://github.com/basecamp/thruster) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More info to make it clear that ports 80 and 443 need to be published to the internet and that certificates are issued via LetsEncrypt.