SSL configuration and authentication for the HTTP check#33
Open
rbague wants to merge 2 commits intobasecamp:masterfrom
Open
SSL configuration and authentication for the HTTP check#33rbague wants to merge 2 commits intobasecamp:masterfrom
rbague wants to merge 2 commits intobasecamp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While implementing some HTTP status checks that we use in one of our applications, I noticed that the HTTP check skips SSL certificate validation in HTTPS requests, and that it does not use the authorization credentials if provided in the URI, which required us to monkey-patch it so we can use it.
This PR fixes both of those things.
Let me know if you need me to change anything in order to get it merged!