Skip to content

Test how basecamp connect fails and recovers, end to end #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robzolkos wants to merge 3 commits into from
Closed

Test how basecamp connect fails and recovers, end to end #826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fa5f93
Report when the connector's backlog warns, pauses and recovers
robzolkos Oct 2, 2026
47d8985
Stop the connector when Basecamp no longer takes its agent's credential
robzolkos Oct 2, 2026
93b287a
Test how basecamp connect fails and recovers, end to end
robzolkos Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion e2e/connect/connector_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,14 @@ type Output struct {
// harness's home.
func (h *Harness) Connect(t *testing.T, extra ...string) *Connector {
t.Helper()
return h.Start(t, h.Home, append([]string{"connect", "-P", Agent}, extra...)...)
return h.ConnectProfile(t, DefaultAgent, extra...)
}

// ConnectProfile starts `basecamp connect` for p's profile with extra
// flags, in the harness's home.
func (h *Harness) ConnectProfile(t *testing.T, p Profile, extra ...string) *Connector {
t.Helper()
return h.Start(t, h.Home, append([]string{"connect", "-P", p.Name}, extra...)...)
}

// Start starts a CLI command in the background, in dir, with the harness's
Expand Down Expand Up @@ -209,6 +216,9 @@ func (c *Connector) WaitStreaming(t *testing.T, nth int) {
c.WaitLogged(t, MsgStreaming, nth)
}

// Pid is the process's id.
func (c *Connector) Pid() int { return c.cmd.Process.Pid }

// Signal sends sig to the process as it stands. Interrupt is the safe way
// to send SIGINT.
func (c *Connector) Signal(t *testing.T, sig os.Signal) {
Expand Down
Loading
Loading