Skip to content

fix: validate certificate field tags#67

Draft
leopoldjoy wants to merge 1 commit into
mainfrom
audit/validate-asn1-field-tags
Draft

fix: validate certificate field tags#67
leopoldjoy wants to merge 1 commit into
mainfrom
audit/validate-asn1-field-tags

Conversation

@leopoldjoy

Copy link
Copy Markdown
Contributor

Summary

  • require serial and issuer ASN.1 tags during certificate identity/parsing
  • require OBJECT IDENTIFIER tags for extension and public-key OIDs
  • add tag-substitution regressions, including computeCertId

Audit finding

Addresses external finding #6.

Tests

  • forge fmt --check
  • CertManager tests: 44 passed, 1 skipped
  • ASN.1 tests: 35 passed

Size note

The isolated parser fix compiles and tests successfully, but production CertManager is 24,712 bytes, 136 bytes over EIP-170. This PR is intentionally isolated for review; it requires bytecode reclamation before merge.

Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant