Skip to content

fix: allow omitted optional public key#66

Draft
leopoldjoy wants to merge 1 commit into
mainfrom
audit/allow-omitted-public-key
Draft

fix: allow omitted optional public key#66
leopoldjoy wants to merge 1 commit into
mainfrom
audit/allow-omitted-public-key

Conversation

@leopoldjoy

Copy link
Copy Markdown
Contributor

Summary

  • accept an omitted optional public_key field as an unset pointer
  • preserve explicit null handling and reject explicit empty byte strings
  • add validation coverage for omitted, null, empty, and valid public keys

Audit finding

Addresses external finding #8.

Tests

  • forge fmt --check
  • forge test --match-path test/IndefiniteLengthCbor.t.sol (68 passed)
  • forge build --sizes
  • NitroValidator runtime: 17,287 bytes

Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant