fix(L1): require a minimum protocol version to schedule an activation - #435
Merged
jackchuma merged 2 commits intoSep 11, 2026
Merged
Conversation
ProtocolVersions.initialize rejects an imported non-zero timestamp paired with a zero minimum protocol version, but the pairing was only enforced at that boundary. registerUpgrade and setTimestamp could still schedule an activation against a registry whose minimum version was zero, which initialize explicitly permits for an empty or zero-only schedule. Nodes attach the contract's global minimum to every timestamp they read, so any positive activation at version zero makes the whole schedule unreadable: strict modes abort startup and the runtime refresher declines to apply it. Enforce the pairing on every write path via a shared assertion. registerUpgrade counts a version supplied in the same call, so a first activation stays a single transaction. setTimestamp cannot supply one, so a registry at zero must call setMinimumProtocolVersion first; that ordering is what removes the window in which a live schedule would be unreadable. delayTimestamp is deliberately exempt: it requires an already-scheduled activation so it cannot introduce the pairing, and guarding it would strand the incident responder on a registry upgraded into this implementation while already holding a zero version. Also ship a non-zero protocolVersionsInitialMinimumVersion in the deploy config. The field is read with a zero default, so the standard deployment previously produced a registry at zero and its first hardfork would have hit the new guard. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
✅ Heimdall Review Status
|
Co-authored-by: Codex <codex-noreply@coinbase.com>
jackchuma
deleted the
fix/protocol-versions-schedule-requires-minimum-version
branch
September 11, 2026 15:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
ProtocolVersions.initializeto receive a non-zero initial minimum protocol version, including when the imported upgrade schedule is empty or contains only unscheduled entries. This ensures a newly initialized registry always supplies the protocol-version floor that nodes need to validate it.protocolVersionsInitialMinimumVersionwhile reading deployment configuration, and set the local configuration to packed version1.0.0.ProtocolVersionssemver lock hashes.Notes to reviewers
0x1000000000000000000000000is packed semver1.0.0(major << 96).