Skip to content

feat(b20): add issuer-authorized spender allowances - #223

Open
stephancill wants to merge 3 commits into
mainfrom
stephancilliers/b20-operator-role
Open

feat(b20): add issuer-authorized spender allowances#223
stephancill wants to merge 3 commits into
mainfrom
stephancilliers/b20-operator-role

Conversation

@stephancill

@stephancill stephancill commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Token issuers need to authorize trusted integrations to spend from every holder without per-holder approvals while keeping that authority separate from Asset operations. This adds a dedicated spender role while preserving the existing operator role.

  • Add shared AUTHORIZED_SPENDER_ROLE support to Asset and Stablecoin.
  • Return infinite effective allowance without changing stored holder allowances.
  • Keep OPERATOR_ROLE Asset-only for announcements and multiplier administration.
  • Preserve pause, transfer policies, delegable administration, and the no-opt-out model.
  • Add variant-specific separation tests and Denim migration documentation.

type=nonroutine
risk=medium
impact=sev4
backwards_compatible=false
automerge=false

@stephancill OpenCode
feat(b20): add issuer-approved operator allowances
57629a7 
Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown

Interface Coverage

✅ All interface functions have test coverage.

@github-actions

github-actions Bot commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown

📊 Forge Coverage (src/lib/)

🟡 ≥95% across all metrics — some metrics below 99%.

File Lines Stmts Branches Funcs
🟡 B20FactoryLib.sol 97.70% 98.00% 100.00% 95.00%
🔴 test/lib/ForceFeeder.sol 0.00% 0.00% 100.00% 0.00%
🔴 test/lib/PrecompileProbe.sol 0.00% 0.00% 0.00% 0.00%
🟢 MockActivationRegistry.sol 100.00% 100.00% 100.00% 100.00%
🟢 MockActivationRegistryStorage.sol 100.00% 100.00% 100.00% 100.00%
🟢 MockB20.sol 100.00% 100.00% 100.00% 100.00%
🟢 MockB20Asset.sol 100.00% 100.00% 100.00% 100.00%
🟡 MockB20Factory.sol 98.96% 99.10% 100.00% 100.00%
🟢 MockB20Stablecoin.sol 100.00% 100.00% 100.00% 100.00%
🟢 MockB20Storage.sol 100.00% 100.00% 100.00% 100.00%
🟡 MockPolicyRegistry.sol 100.00% 99.54% 97.67% 100.00%
🟢 MockPolicyRegistryStorage.sol 100.00% 100.00% 100.00% 100.00%
Total 97.08% 97.53% 98.18% 97.00%

Full report: download artifact. To browse locally: make coverage (runs forge coverage + genhtml + opens the HTML report).

@github-actions

github-actions Bot commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ Fork tests: 32 failed, 737 passed

These failures indicate divergences where base/base needs to catch up to the base-std spec. This check is advisory and does not block merging.

Failing tests
  • test_allowance_success_authorizedSpenderReadsAsInfinite(address,uint256): authorized spender allowance must be infinite: 11308 != 115792089237316195423570985008687907853269984665640564039457584007913129639935; counterexample: calldata=0x32f8df9500000000000000000000000055aa69c84b24892aaef76eeac52e0e2b3a0b86000000000000000000000000000000000000000000000000000000000000002c2c args=[0x55aA69c84B24892aAEF76EEac52E0E2B3a0B8600, 11308 [1.13e4]]
  • test_allowance_success_authorizedSpenderReadsAsInfinite(address,uint256): authorized spender allowance must read as infinite: 2 != 115792089237316195423570985008687907853269984665640564039457584007913129639935; counterexample: calldata=0x32f8df95000000000000000000000000e1149f4da1c0ed5a7f1a984d2bcca414a6c52c6a0000000000000000000000000000000000000000000000000000000000000002 args=[0xe1149F4da1C0ED5A7F1A984D2bCcA414a6c52c6a, 2]
  • test_transferFromWithMemo_revert_authorizedSpenderExecutorPolicyForbids(address,address,uint256,bytes32): Error != expected error: InsufficientAllowance(0x524E8eFDF667C44894B4f160B04b5d7a4F7310Bb, 0, 259663646447008659379791766158669666160 [2.596e38]) != PolicyForbids(0x10be5173aff2a44e748bd9acd8b19fe34689581398a9db7ba2fb671e786ff7d8, 72057594037927937 [7.205e16]); counterexample: calldata=0x6262c8500000000000000000000000000cfbeff8a22475193407f336201da75572650ee10000000000000000000000008e30f446d3e3b245384b120ab6eeb1d977849a1c0000000efef32bb53ef1eb823a49d2dbc359663306dd6e5b25b11e6edf9a57702bfcbc339c496485ae62e19b5f259e9048255bbcfb6d1472802357691973ff28 args=[0x0cfBEFf8a22475193407f336201dA75572650eE1, 0x8e30F446d3e3B245384b120aB6eeB1d977849a1C, 404288610061814469960131107852441599006543912228555011129838854100848 [4.042e68], 0x2bfcbc339c496485ae62e19b5f259e9048255bbcfb6d1472802357691973ff28]
  • test_transferFromWithMemo_revert_authorizedSpenderExecutorPolicyForbids(address,address,uint256,bytes32): Error != expected error: InsufficientAllowance(0x524E8eFDF667C44894B4f160B04b5d7a4F7310Bb, 0, 269820994764483720502502024164341497418 [2.698e38]) != PolicyForbids(0x10be5173aff2a44e748bd9acd8b19fe34689581398a9db7ba2fb671e786ff7d8, 72057594037927937 [7.205e16]); counterexample: calldata=0x6262c8500000000000000000000000005360c66e76c2c5a4583f1dcbac287665cf46746e000000000000000000000000aa51319f40d1e9b7e4012c7525ec51efbb3875c00000000000000000875740642b42aaa7cafda222d738eacab2136e9d5354be4a9e4e08049c75b02101c3f56b5f4fe4eb442bcee6aa58f89b3d03d534721148d4 args=[0x5360c66E76C2c5A4583f1dCBAc287665cF46746E, 0xaA51319F40D1E9B7E4012C7525EC51efBb3875C0, 3318547404413741285839169550618083727111984257424914955850 [3.318e57], 0x9e4e08049c75b02101c3f56b5f4fe4eb442bcee6aa58f89b3d03d534721148d4]
  • test_transferFromWithMemo_success_authorizedSpenderSpendsAfterHolderApprovesZero(address,address,uint256,bytes32): InsufficientAllowance(0x524E8eFDF667C44894B4f160B04b5d7a4F7310Bb, 0, 66745419376597806416622439528738958690 [6.674e37]); counterexample: calldata=0x7ea6764900000000000000000000000073f41eec626a75c866887a01e03d6d2847e0ff4e000000000000000000000000e4c3e49d43a8f77d594a71e394f5ef0d9c61ec8e00000000000000000000000144b8d8913236b33f2e32e56537d7f29cffe5ad624fceaf923560aae02de089fa52092424f433cfdc4155d05c232cdf518de54cc5 args=[0x73F41Eec626A75C866887A01e03d6d2847E0ff4e, 0xe4C3e49D43a8f77D594a71E394f5ef0D9C61Ec8E, 1853835212524903523635531867936946059459290312034 [1.853e48], 0x4fceaf923560aae02de089fa52092424f433cfdc4155d05c232cdf518de54cc5]
  • test_transferFromWithMemo_success_authorizedSpenderSpendsWithoutAllowance(address,address,uint256,bytes32): InsufficientAllowance(0x524E8eFDF667C44894B4f160B04b5d7a4F7310Bb, 0, 17772473138145773661 [1.777e19]); counterexample: calldata=0x5b7f51c8000000000000000000000000e4cd087462d121f461f45642c5c50bb641ea7dbb000000000000000000000000163537c265e3c9e58bb0850ed102ed9c9f1e223c000000000000000000000000000000000000000000000000f6a482281359c85d92849aecd86b45313fa726e0d2daf9b5a75febffebd4e8a0ae69f9b82c981991 args=[0xE4Cd087462D121f461f45642c5c50BB641EA7dbB, 0x163537c265e3c9e58BB0850ED102ed9c9F1E223C, 17772473138145773661 [1.777e19], 0x92849aecd86b45313fa726e0d2daf9b5a75febffebd4e8a0ae69f9b82c981991]
  • test_transferFrom_revert_authorizedSpenderExecutorPolicyForbids(address,address,uint256): Error != expected error: InsufficientAllowance(0x524E8eFDF667C44894B4f160B04b5d7a4F7310Bb, 0, 237242869862598699955013579928977333731 [2.372e38]) != PolicyForbids(0x10be5173aff2a44e748bd9acd8b19fe34689581398a9db7ba2fb671e786ff7d8, 72057594037927937 [7.205e16]); counterexample: calldata=0xd7f62992000000000000000000000000f82c73735bace2f13d6e2200979c7ab9da0f03f100000000000000000000000072d5e4fcc83eca711b91ffe98c4fc6ae20a73666000000000015781a42a359595a368a5cb27b50913b8e9f0986ffb7f271b0dde3 args=[0xF82c73735bAce2f13D6E2200979C7Ab9da0f03F1, 0x72d5e4FCc83EcA711b91FFE98c4Fc6AE20A73666, 8831896329853549527004492956965647289388289038234867244037365219 [8.831e63]]
  • test_transferFrom_revert_authorizedSpenderExecutorPolicyForbids(address,address,uint256): Error != expected error: InsufficientAllowance(0x524E8eFDF667C44894B4f160B04b5d7a4F7310Bb, 0, 289467165826535462408897441672177647231 [2.894e38]) != PolicyForbids(0x10be5173aff2a44e748bd9acd8b19fe34689581398a9db7ba2fb671e786ff7d8, 72057594037927937 [7.205e16]); counterexample: calldata=0xd7f6299200000000000000000000000084c77a247ac713f4a4ff3bbcb0e591bb8e16205200000000000000000000000008898cd2ad4d72612fbae5da8cf5e3105180fb2f000000000000029ec9c30f682734edefd9c55927736e717c5af02945ffe7fe7f args=[0x84C77A247Ac713f4a4fF3BbcB0e591Bb8E162052, 0x08898cd2ad4d72612FBaE5DA8cf5E3105180Fb2F, 4210605351422291401998042881359136003697895505388074875485823 [4.21e60]]
  • test_transferFrom_revert_authorizedSpenderReceiverPolicyForbids(address,address,uint256): Error != expected error: InsufficientAllowance(0x524E8eFDF667C44894B4f160B04b5d7a4F7310Bb, 0, 57) != PolicyForbids(0x8a4b3fa2d8b921852bc0089c6ef0958aa6961897be36fd731330fe2cd23f8363, 72057594037927937 [7.205e16]); counterexample: calldata=0xdca0d67b00000000000000000000000078b704b086da590558ee1b47ab4de8d79aeb4efa0000000000000000000000000a5e544ec507ea1310c0d4532bed1f01de519c6b0000000000000000000000000000000000000000000000000000000000000039 args=[0x78B704b086dA590558ee1b47aB4dE8d79aEb4eFA, 0x0a5e544Ec507eA1310C0d4532Bed1F01De519c6B, 57]
  • test_transferFrom_revert_authorizedSpenderSenderPolicyForbids(address,address,uint256): Error != expected error: InsufficientAllowance(0x524E8eFDF667C44894B4f160B04b5d7a4F7310Bb, 0, 22970937812135840122058768293674832052 [2.297e37]) != PolicyForbids(0xb81736c875ab819dd97f59f2a6542cfb731ad52b4ae15a6f24df2fb02b0327f5, 72057594037927937 [7.205e16]); counterexample: calldata=0x118d362a0000000000000000000000004e50d245caff54534ae8619d1751e96b8521aeb0000000000000000000000000bbe6dd635ecd42a3668e6e6f83746f63b06b34c7010bba2420ae0a657f96bd2217dee4a311480aacbd780793062c4c7bee3350b4 args=[0x4E50d245cAfF54534AE8619D1751E96B8521aeb0, 0xBbe6dd635Ecd42A3668e6E6f83746f63B06b34c7, 473032865116001166419725054283574141663127637660855396766845530379996319924 [4.73e74]]
  • test_transferFrom_success_authorizedSpenderPreservesStoredAllowance(address,address,uint256,uint256): InsufficientAllowance(0x524E8eFDF667C44894B4f160B04b5d7a4F7310Bb, 140071082103761146810003043662114 [1.4e32], 166234121593315743704285113881666273190 [1.662e38]); counterexample: calldata=0xa96712640000000000000000000000007770f92105828fcb36af1628d7f9b9f49dc2fa36000000000000000000000000b080f60674eb69753ecd8d7b832b05c88617b99100000000000000000000000000000000000006e7f2137edcaa30eab19588392200000000000000000000013ba599c0d67d0f86fa383566d824bcb99ccda03fa6 args=[0x7770F92105828FcB36Af1628D7f9B9f49Dc2Fa36, 0xB080f60674Eb69753EcD8D7b832b05c88617b991, 140071082103761146810003043662114 [1.4e32], 461318428048981287481641349087016688771492971823014 [4.613e50]]
  • test_transferFrom_success_authorizedSpenderPreservesStoredAllowance(address,address,uint256,uint256): authorized spender allowance must remain infinite: 119525425988822156657774956444643229146920207690690463 != 115792089237316195423570985008687907853269984665640564039457584007913129639935; counterexample: calldata=0xa96712640000000000000000000000008b621a3a1055b0e0f767a41935f112bc1525f473000000000000000000000000f3be721ee332c4e47b541e4da1f73041671976c9000000000000000000013f769d7c595814c421752a08159f4c889878f3e1a2e8000000000000000000c533848036373a660ee0bab237cb277dda376269d2b349 args=[0x8b621A3a1055b0e0F767a41935f112bc1525f473, 0xf3Be721ee332C4e47b541E4da1f73041671976c9, 119525425988822292316280733870777516642313834114163432 [1.195e53], 18888126362464246470156564724269968786328733194948621129 [1.888e55]]
  • test_transferFrom_success_authorizedSpenderSpendsAfterHolderApprovesZero(address,address,uint256): InsufficientAllowance(0x524E8eFDF667C44894B4f160B04b5d7a4F7310Bb, 0, 103712096941906004729621016897 [1.037e29]); counterexample: calldata=0x5e96790e0000000000000000000000001757f3426710c0844b63ada3f9b0d8fe63fd6b66000000000000000000000000e7b3b36c32333a75f55c23abf7bb23c542c7a91900000000000000000000000000000000000000014f1ca2c8df41107b40767141 args=[0x1757f3426710c0844b63ada3F9b0D8Fe63fd6B66, 0xe7B3B36c32333a75f55c23aBf7Bb23c542C7A919, 103712096941906004729621016897 [1.037e29]]
  • test_transferFrom_success_authorizedSpenderSpendsWithoutAllowance(address,address,uint256): InsufficientAllowance(0x524E8eFDF667C44894B4f160B04b5d7a4F7310Bb, 0, 175390816331545678889717827279367755451 [1.753e38]); counterexample: calldata=0xe653bb95000000000000000000000000a287856f061f9a53d1b92b4383144daa7a46479c0000000000000000000000005c455ce036409fd39e0d6a0fbc2394cc735b9233000000000011176caa575587342ab47c83f30ae2385786612143c8831bd0d6bb args=[0xA287856f061f9A53D1B92b4383144dAA7A46479c, 0x5C455CE036409Fd39e0D6a0FbC2394Cc735B9233, 7031036047373319751863777903721761106770208260826217978142971579 [7.031e63]]
    [FAIL: custom error 0xef97aa21] test_AUTHORIZED_SPENDER_ROLE_success_matchesExpected() (gas: 5186)

stephancill
stephancill commented Sep 10, 2026
View reviewed changes
Comment thread changelog/03_Denim_B20_authorized_spender.md

@stephancill stephancill Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1

Comment thread src/interfaces/IB20.sol

@stephancill stephancill Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2

Comment thread src/interfaces/IB20Asset.sol

@stephancill stephancill Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3

Comment thread src/lib/B20FactoryLib.sol

@stephancill stephancill Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4

@stephancill OpenCode
refactor(b20): separate spender authority from operators
6161f39 
Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
@stephancill stephancill changed the title feat(b20): add issuer-approved operator allowances feat(b20): add issuer-authorized spender allowances Sep 10, 2026
@stephancill OpenCode
chore: remove unrelated operator changes
aad0b9a 
Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
stephancill
stephancill commented Sep 10, 2026
View reviewed changes
Comment thread src/lib/B20Constants.sol

@stephancill stephancill Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevieraykatz stevieraykatz Awaiting requested review from stevieraykatz stevieraykatz is a code owner
@amiecorso amiecorso Awaiting requested review from amiecorso amiecorso is a code owner
@eric-ships eric-ships Awaiting requested review from eric-ships eric-ships is a code owner
@ilikesymmetry ilikesymmetry Awaiting requested review from ilikesymmetry ilikesymmetry is a code owner
@rayyan224 rayyan224 Awaiting requested review from rayyan224 rayyan224 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@stephancill