feature: ios sourcemap upload script fails debug builds and manual runs - #395
Draft
KishanPRao wants to merge 1 commit into
Draft
feature: ios sourcemap upload script fails debug builds and manual runs#395KishanPRao wants to merge 1 commit into
KishanPRao wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ios-sourcemap-upload.shexited 1 whenever the source map or debug id file was missing.Every Debug build is missing them by design. All Debug and simulator builds failed with xcodebuild error 65, and the script could not run outside Xcode.
Changes
packages/react-native/scripts/ios-sourcemap-upload.sh: skips Debug configurations andSKIP_BUNDLINGbuilds inside Xcode, reports a missing source map, debug id, config,backtrace-jsor node as an Xcodewarning:instead of failing the build, keeps them as errors outside Xcode, sourcesios/.xcode.envlike React Native's own phase, drops theREACT_NATIVE_PATHdependency, documents environment and behavior in the usage header.packages/react-native/tests/scripts/iosSourcemapUploadScript.spec.ts: new, drives the script through Xcode Debug/Release/custom configurations,SKIP_BUNDLING, missing inputs,.xcode.envnode resolution,DEBUG_ID_PATH, upload failure, and manual runs.ref: BT-7405