Fix Pi feedback delivery after reload - #1240
Merged
backnotprop merged 1 commit intoAug 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A Plannotator browser tab can outlive a Pi
/reload. When its feedback arrives, the old callback correctly finds a newly registered Pi runtime, butcurrent-pi-session.tsrejects that runtime assame-sessionbecause reload preserves the Pi session ID and file.The callback then falls through to the stale captured
piobject and reports:The notification fallback fails for the same reason.
Fix
Track the in-process extension runtime token as part of
PiSessionIdentity. A reload now counts as a different active runtime even when its persistent session ID is unchanged. Existing session-ID/file comparison remains the fallback for identities without runtime tokens.Test
Added a regression test that registers a replacement runtime with the same session ID and verifies both feedback and notification delivery go only to the replacement.
Focused command: