fix(review): update Codex automatic approval flag - #1231
Open
leoreisdias wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Codex CLI 0.147 removed the
--full-autoargument. Plannotator still passed it when launching Codex review jobs, so standard review, Guided Review, and Code Tour failed before the agent could start:Fix
--full-autowith the current--approve-for-meflag in all three Codex command builders.Review focus
The important invariant is that every Codex review surface launches with the same supported approval flag. The new test deliberately checks all three builders together so future CLI migrations cannot fix one surface while leaving another broken.
Test plan
tsc --noEmitwith TypeScript 5.8.3.git diff --checkpasses.Environment note: this worktree's root
bun run typecheckwrapper could not locatetsc, so the same seven project configurations were run directly with the existing TypeScript 5.8.3 compiler.