ci: glob the OpenCode smoke tarball instead of pinning the version - #1203
Merged
Conversation
The installed-package smoke passed a hardcoded plannotator-opencode-0.25.1.tgz path to the fixture, so every version bump would silently break the job on the bump commit. npm pack writes exactly one plannotator-opencode-*.tgz into RUNNER_TEMP, so a glob resolves to the same file and survives bumps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: One line in CI. The OpenCode 2 installed-package smoke passed a hardcoded
plannotator-opencode-0.25.1.tgzpath, so the next version bump would have broken theTestworkflow on the bump commit. It now globsplannotator-opencode-*.tgz, which resolves to the single tarballnpm packwrites intoRUNNER_TEMPin the prior step. CI-only; no user-facing behavior.The hardcoded name came in with #1194 when the job was created. #1202 repaired the job's timeouts but left the pin in place; this removes it before the v0.26.0 bump trips it.
AI-assisted.