Skip to content

Bulk arrays #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
borkdude merged 3 commits into from
Aug 29, 2026
Merged

Bulk arrays #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4857a8b
Blobs go through read-array and write-array
borkdude Aug 29, 2026
b849209
Pin babashka/ffi to the bulk arrays merge
borkdude Aug 29, 2026
93d4d2d
Fix the ffi sha: the previous commit had 41 characters
borkdude Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deps.edn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
;; babashka/ffi repository.
:deps {io.github.babashka/ffi
{:git/url "https://github.com/babashka/ffi"
:git/sha "40fcd2784b94a062e98b4de29431450e852c57ca"}}
:git/sha "e4700ac76a61f7f3a7755fafa5784a2f86f6d137"}}
:aliases
{:test {:extra-paths ["test"]
:extra-deps {io.github.cognitect-labs/test-runner
Expand Down
6 changes: 3 additions & 3 deletions src/babashka/sqlite.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@
^bytes [n p]
(if (pos? n)
;; a pointer from C has size 0; give it the blob's size first
(ffi/read-bytes (ffi/reinterpret p n) n)
(ffi/read-array (ffi/reinterpret p n) :byte n)
(byte-array 0)))

;; sqlite types values per cell, not per column
Expand All @@ -166,7 +166,7 @@
(bytes? v) (with-open [arena (ffi/confined-arena)]
(let [n (alength ^bytes v)
p (ffi/alloc arena (max n 1))]
(ffi/write-bytes p v)
(ffi/write-array p :byte v)
(c-bind-blob stmt i p n sqlite-transient)))
:else (throw (ex-info (str "sqlite3: cannot bind " (type v))
{:value v})))]
Expand Down Expand Up @@ -227,7 +227,7 @@
(bytes? v) (with-open [arena (ffi/confined-arena)]
(let [n (alength ^bytes v)
p (ffi/alloc arena (max n 1))]
(ffi/write-bytes p v)
(ffi/write-array p :byte v)
(c-result-blob ctx p n sqlite-transient)))
:else (c-result-error ctx (str "cannot return " (type v) " from a function") -1)))

Expand Down
Loading