Skip to content

build(cmake): enable verify_private_header_sets #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
b1ackviking merged 1 commit into from
Apr 1, 2026
+24 −25
Merged

build(cmake): enable verify_private_header_sets #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 4.2 FATAL_ERROR)
cmake_minimum_required(VERSION 4.3 FATAL_ERROR)

project(
cpp-project-template
Expand Down
2 changes: 1 addition & 1 deletion cmake/defaults.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ set(CMAKE_C_EXTENSIONS OFF)
set(CMAKE_CXX_EXTENSIONS OFF)
set(CMAKE_CXX_SCAN_FOR_MODULES ON)
set(CMAKE_VERIFY_INTERFACE_HEADER_SETS ON)
# TODO: set(CMAKE_VERIFY_PRIVATE_HEADER_SETS ON) with cmake 4.3
set(CMAKE_VERIFY_PRIVATE_HEADER_SETS ON)
set(CMAKE_LINK_WHAT_YOU_USE TRUE)
set(CMAKE_VS_JUST_MY_CODE_DEBUGGING ON)
set(CMAKE_COLOR_DIAGNOSTICS ON)
Expand Down
3 changes: 1 addition & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ dev = [
"ninja",
"pre-commit",
"clang-format",
#TODO: remove version after https://github.com/scikit-build/cmake-python-distributions/issues/692
"cmake==4.3.0",
"cmake",
]

[tool.uv]
Expand Down
42 changes: 21 additions & 21 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading