Skip to content

Pin the three tools that prepare a release - #259

Merged
aywrite merged 1 commit into
masterfrom
ci/pin-release-tools
Sep 15, 2026
Merged

aywrite merged 1 commit into
masterfrom
ci/pin-release-tools

Conversation

@aywrite

@aywrite aywrite commented Sep 15, 2026

Copy link
Copy Markdown
Owner

git-cliff@2 floated on a major and cargo binstall --no-confirm cargo-release
took whatever was newest, so the two tools that write the release commit and the
changelog were unpinned, and so was the cargo-binstall that fetches one of
them. This is item 5 of v0.5.0's hygiene list, the pins half.

All three are pinned to the versions that cut v0.4.4, read off that run rather
than chosen: git-cliff 2.14.1, cargo-binstall 1.23.0, cargo-release 1.1.5. So
the release path is on tools known to have produced a good release.

cargo-release stays behind cargo binstall rather than joining the other two in
taiki-e/install-action: that action's tool list does not carry it.

The cost is that the pins go stale quietly. Dependabot bumps the uses: line
but not a version inside tool: or a run:, so these three want bumping by
hand, and the comment beside them says so.

The other half of that item, the Miri sentence, needs no change. See the review
comment below.

🤖 Generated with Claude Code

`git-cliff@2` floated on a major and `cargo binstall --no-confirm
cargo-release` took whatever was newest, so the two tools that write the
release commit and the changelog were both unpinned, and so was the
`cargo-binstall` that fetches one of them. A release cut today and the same
release cut next month were not made by the same tools.

All three are pinned to the versions that cut v0.4.4, read off that run
rather than chosen: git-cliff 2.14.1, cargo-binstall 1.23.0 and cargo-release
1.1.5.

cargo-release stays behind `cargo binstall` rather than joining the other two
in `taiki-e/install-action`, because that action does not carry it.

What the pins cost is that they go stale quietly. Dependabot bumps the
`uses:` line above them but not a version inside `tool:` or inside a `run:`,
so these three are bumped by hand, which the comment beside them now says.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Speed against 1a5e362a

Both sides built and run on this runner in this job, the way
scripts/speed.sh measures a perf commit. The change is between
medians, and the spread beside it is what the change has to be
read against. The node counts are the search's: they move when
the search does, and a speed change leaves them alone.

round     base nps  candidate nps
    1      7693153        7688445
    2      7675678        7725813
    3      7832908        7781785
    4      7798600        7867728
    5      7779845        7817825
    6      7799543        7726276
    7      7639304        7648547
    8      7782709        7754693
    9      7774436        7692083

             nodes    time  median nps  fastest nps
base       3868987  0.50 s     7779845      7832908
candidate  3868987  0.50 s     7726276      7867728
change                           -0.7%        +0.4%

the change is inside the spread, so the medians make no claim; the
fastest column is the steadier comparison when the machine was not
quiet

Speed: -0.7% (bench nps, 9 interleaved rounds vs 1a5e362a, spread 2.8%)

@aywrite
aywrite merged commit 9e4bb4c into master Sep 15, 2026
20 checks passed
@aywrite
aywrite deleted the ci/pin-release-tools branch September 15, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant