Repository navigation
Pin the three tools that prepare a release - #259
Merged
Merged
Conversation
`git-cliff@2` floated on a major and `cargo binstall --no-confirm cargo-release` took whatever was newest, so the two tools that write the release commit and the changelog were both unpinned, and so was the `cargo-binstall` that fetches one of them. A release cut today and the same release cut next month were not made by the same tools. All three are pinned to the versions that cut v0.4.4, read off that run rather than chosen: git-cliff 2.14.1, cargo-binstall 1.23.0 and cargo-release 1.1.5. cargo-release stays behind `cargo binstall` rather than joining the other two in `taiki-e/install-action`, because that action does not carry it. What the pins cost is that they go stale quietly. Dependabot bumps the `uses:` line above them but not a version inside `tool:` or inside a `run:`, so these three are bumped by hand, which the comment beside them now says. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Speed against
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git-cliff@2floated on a major andcargo binstall --no-confirm cargo-releasetook whatever was newest, so the two tools that write the release commit and the
changelog were unpinned, and so was the
cargo-binstallthat fetches one ofthem. This is item 5 of v0.5.0's hygiene list, the pins half.
All three are pinned to the versions that cut v0.4.4, read off that run rather
than chosen: git-cliff 2.14.1, cargo-binstall 1.23.0, cargo-release 1.1.5. So
the release path is on tools known to have produced a good release.
cargo-release stays behind
cargo binstallrather than joining the other two intaiki-e/install-action: that action's tool list does not carry it.The cost is that the pins go stale quietly. Dependabot bumps the
uses:linebut not a version inside
tool:or arun:, so these three want bumping byhand, and the comment beside them says so.
The other half of that item, the Miri sentence, needs no change. See the review
comment below.
🤖 Generated with Claude Code