examples/proxy: free cd[1] stat buckets in handle_close#1585
Open
rootvector2 wants to merge 1 commit into
Open
examples/proxy: free cd[1] stat buckets in handle_close#1585rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
When extended stats are enabled (-x), the per-connection setup allocates rcv_bucket and snd_bucket for both directions, c->cd[0] and c->cd[1]. handle_close() only frees the cd[0] pair, so the two cd[1] arrays leak on every connection teardown. Free them too, mirroring the cd[0] cleanup. Signed-off-by: rootvector2 <dxbnaveed.k@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With -x (extended stats), each connection allocates rcv_bucket and snd_bucket for both c->cd[0] and c->cd[1] (examples/proxy.c:996), but handle_close only frees the cd[0] pair, leaking the cd[1] arrays on every teardown. Free them too, mirroring the existing cd[0] cleanup.