Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses intermittent CI crashes (SIGSEGV) during swift package archive on Linux by replacing FileHandle.readabilityHandler with a manual blocking read loop. The crashes were caused by the readability handler's setter triggering Objective-C bridging code that conflicts with concurrent Swift runtime metadata resolution.
Changes:
- Removed
FileHandle.readabilityHandlerusage which caused crashes due to_bridgeAnythingToObjectiveC/swift_dynamicCastcalls - Implemented manual read loop using
availableDatain an async block to avoid problematic Foundation/ObjC bridging - Removed the post-process
readToEnd()call as the new read loop handles all data
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Related to intermittent CI crashes with Signal 11 (SIGSEGV) during
swift package archiveon Linux x86_64 (Ubuntu 24.04)Description of the changes
Replaces
FileHandle.readabilityHandlerwith a manual blocking read loop usingavailableDataon a serialDispatchQueuein theUtils.executemethod of the AWSLambdaPackager plugin.On Linux,
FileHandle.readabilityHandler's setter internally calls_bridgeAnythingToObjectiveC, which triggersswift_dynamicCast/swift_conformsToProtocol. When the Swift runtime is concurrently resolving type metadata on other threads, this causes a bad pointer dereference crash in_dispatch_event_loop_drain. The new approach uses awhileloop callingavailableData(blocks until data arrives, returns emptyDataat EOF), completely avoiding the problematic Foundation/ObjC bridging code paths.New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
Conventional Commits
fix: replace FileHandle.readabilityHandler with manual read loop in AWSLambdaPackager pluginBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.