Remove fix for s2n-tls on macOS x64#996
Draft
sfod wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
On macOS x64, XCode's Clang has -I/usr/local/include baked in, which can shadow libcrypto headers from imported targets (propagated with -isystem). Currently, CMake config sets
NO_SYSTEM_FROM_IMPORTEDflag forcing-Ifor imported target. With s2n-tls implemented this fix on their side, the local fix is not needed anymore.Description of changes:
Update s2n-tls to get the fix. Remove the local fix.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.