Correcting the storageready repair action - #1222
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
sumanthst25
left a comment
sumanthst25
left a comment
There was a problem hiding this comment.
Correcting the documentation to reflect StorageReady of NMA conditions as Events
|
@prasad0896 Adding you to review this. |
| == Storage node health issues | ||
|
|
||
| The monitoring condition is `StorageReady` for issues in the following table that have a severity of “Condition”. | ||
| The monitoring condition is `StorageReady` for issues in the following table that have a severity of “Event”. |
There was a problem hiding this comment.
This should be Condition only. NMA will only change the status on condition. Subsequently only conditions are considered for any repair action.
There was a problem hiding this comment.
@sumanthst25 could you please address these comments
There was a problem hiding this comment.
None of the current StorageReady scenarios fall under "Condition". All the scenarios are listed under Events category. But this can be ignored considering the future changes that may come in
| |StorageReady indicates whether the node's storage subsystem is functioning correctly (disks, filesystems, I/O). | ||
| |30m | ||
| |Replace | ||
| |N/A |
There was a problem hiding this comment.
Thanks for the change, however I do want to callout that if we ever add a reason to NMA that has DefaultSeverity: Fatal, then repair will be triggered on the node in default cases.
4 participants
Issue #, if available:
Description of changes:
According to the NMA documentation : https://docs.aws.amazon.com/eks/latest/userguide/node-health-nma.html#node-health-Storage and NMA source code : https://github.com/aws/eks-node-monitoring-agent/blob/main/pkg/reasons/reasons.yaml#L341-L367, there is no "condition" for StorageReady that can trigger the replace/reboot of the instance as all the scenarios are events.
Therefore I am creating this PR to correct the docs which say that StorageReady triggers a replace in 30 mins.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.