Skip to content

test: cover construct_s3_location_object with StorageMode #3961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
licjun merged 4 commits into from
Jul 22, 2026
+30 −0
Merged

test: cover construct_s3_location_object with StorageMode #3961

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40b641b
test: cover construct_s3_location_object with StorageMode
Jul 21, 2026
5eaa032
test: drop redundant combined-fields case
Jul 21, 2026
685d7bf
test: use valid StorageMode value REFERENCE
Jul 21, 2026
993277c
test: apply black formatting
Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions tests/model/s3_utils/test_uri_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,36 @@ def test_unresolved_cdk_token_returns_none(self):
self.assertIsNone(parse_s3_uri("s3://bucket-[TOKEN.25]/key"))


class TestConstructS3LocationObject(TestCase):
def test_dict_with_bucket_and_key(self):
Comment thread
licjun marked this conversation as resolved.
result = construct_s3_location_object({"Bucket": "b", "Key": "k"}, "Fn", "CodeUri")
self.assertEqual(result, {"S3Bucket": "b", "S3Key": "k"})

def test_dict_with_version(self):
result = construct_s3_location_object({"Bucket": "b", "Key": "k", "Version": "v1"}, "Fn", "CodeUri")
self.assertEqual(result, {"S3Bucket": "b", "S3Key": "k", "S3ObjectVersion": "v1"})

def test_dict_with_storage_mode(self):
result = construct_s3_location_object({"Bucket": "b", "Key": "k", "StorageMode": "REFERENCE"}, "Fn", "CodeUri")
self.assertEqual(result, {"S3Bucket": "b", "S3Key": "k", "S3ObjectStorageMode": "REFERENCE"})

def test_s3_uri_string(self):
result = construct_s3_location_object("s3://bucket/path/key", "Fn", "CodeUri")
self.assertEqual(result, {"S3Bucket": "bucket", "S3Key": "path/key"})

def test_dict_missing_bucket_raises(self):
with self.assertRaises(InvalidResourceException):
construct_s3_location_object({"Key": "k"}, "Fn", "CodeUri")

def test_dict_missing_key_raises(self):
with self.assertRaises(InvalidResourceException):
construct_s3_location_object({"Bucket": "b"}, "Fn", "CodeUri")

def test_invalid_type_raises(self):
with self.assertRaises(InvalidResourceException):
construct_s3_location_object(42, "Fn", "CodeUri") # type: ignore[arg-type]


class TestConstructS3LocationObjectWithMalformedUri(TestCase):
"""Verify that the top-level helper raises InvalidResourceException with the
logical id instead of letting the underlying urllib ValueError propagate.
Expand Down