Repository navigation
Daily Sync with Botocore v1.43.115 on 2026/10/20 - #6504
sagemaker-bot wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🤖 AI code review
Automated daily botocore sync (v1.43.115). The diff regenerates resources.py, shapes.py, shape_dag.py, config_schema.py, api_coverage.json and the sample service-2 models. Changes are predominantly additive (new pipeline step-metadata shapes AthenaStepMetadata, CleanupStepMetadata/CleanupFailure, EMRServerlessStepMetadata, ForEachStepMetadata/ForEachSelectorResult, IterationContext; new invoke/invoke_with_response_stream prefix_aware_id param; new invoke_async s3_output_path_extension/filename/body params; CompletedWithFailures status; ConflictException relocation). New shapes are defined before use and wired consistently across the three generated files. Two items worth noting: the invoke_async positional-parameter reorder (backward-incompatible for positional callers) and the removal of module docstrings from two generated files.
Reviewed commit 90fbe84. Automated review; verify before acting.
| def invoke_async( | ||
| self, | ||
| input_location: StrPipeVar, | ||
| content_type: Optional[StrPipeVar] = Unassigned(), |
There was a problem hiding this comment.
🟠 Medium: Endpoint.invoke_async makes input_location optional and moves it from the first positional parameter to after content_type/accept/custom_attributes/inference_id. Any existing caller that passed input_location positionally (e.g. endpoint.invoke_async("s3://...")) will now silently bind that value to content_type, producing an incorrect request rather than an error. This faithfully mirrors the upstream botocore change (Body and InputLocation are now mutually exclusive), but it is a backward-incompatible change to a public method signature and should be called out in the release notes. Same pattern as PR 6454/6365. Source: #6454
| @@ -1,5 +1,3 @@ | |||
| """JSON schema definition for the SageMaker Python SDK configuration file.""" | |||
|
|
|||
| SAGEMAKER_PYTHON_SDK_CONFIG_SCHEMA = { | |||
There was a problem hiding this comment.
🟡 Low: The module-level docstring was removed here (and likewise in utils/code_injection/shape_dag.py). pydocstyle (run in the docstyle tox env against src/sagemaker) enforces D100 (missing docstring in public module) by default, and I found no per-file exclusion for these generated files. Confirm the docstyle env still passes, or that these generated modules are exempt. Source: #6454
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6504 +/- ##
==========================================
+ Coverage 73.23% 73.24% +0.01%
==========================================
Files 573 573
Lines 71818 71854 +36
==========================================
+ Hits 52595 52631 +36
Misses 19223 19223 🚀 New features to boost your workflow:
|
Daily sync with Botocore package. This PR is automatically generated by sagemaker-bot.