Skip to content

Daily Sync with Botocore v1.43.115 on 2026/10/20 - #6504

Open
sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-10-20-10-05-03
Open

sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-10-20-10-05-03

Conversation

@sagemaker-bot

Copy link
Copy Markdown
Collaborator

Daily sync with Botocore package. This PR is automatically generated by sagemaker-bot.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI code review

Automated daily botocore sync (v1.43.115). The diff regenerates resources.py, shapes.py, shape_dag.py, config_schema.py, api_coverage.json and the sample service-2 models. Changes are predominantly additive (new pipeline step-metadata shapes AthenaStepMetadata, CleanupStepMetadata/CleanupFailure, EMRServerlessStepMetadata, ForEachStepMetadata/ForEachSelectorResult, IterationContext; new invoke/invoke_with_response_stream prefix_aware_id param; new invoke_async s3_output_path_extension/filename/body params; CompletedWithFailures status; ConflictException relocation). New shapes are defined before use and wired consistently across the three generated files. Two items worth noting: the invoke_async positional-parameter reorder (backward-incompatible for positional callers) and the removal of module docstrings from two generated files.

Reviewed commit 90fbe84. Automated review; verify before acting.

def invoke_async(
self,
input_location: StrPipeVar,
content_type: Optional[StrPipeVar] = Unassigned(),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Medium: Endpoint.invoke_async makes input_location optional and moves it from the first positional parameter to after content_type/accept/custom_attributes/inference_id. Any existing caller that passed input_location positionally (e.g. endpoint.invoke_async("s3://...")) will now silently bind that value to content_type, producing an incorrect request rather than an error. This faithfully mirrors the upstream botocore change (Body and InputLocation are now mutually exclusive), but it is a backward-incompatible change to a public method signature and should be called out in the release notes. Same pattern as PR 6454/6365. Source: #6454

@@ -1,5 +1,3 @@
"""JSON schema definition for the SageMaker Python SDK configuration file."""

SAGEMAKER_PYTHON_SDK_CONFIG_SCHEMA = {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Low: The module-level docstring was removed here (and likewise in utils/code_injection/shape_dag.py). pydocstyle (run in the docstyle tox env against src/sagemaker) enforces D100 (missing docstring in public module) by default, and I found no per-file exclusion for these generated files. Confirm the docstyle env still passes, or that these generated modules are exempt. Source: #6454

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.24%. Comparing base (3ecabcf) to head (90fbe84).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6504      +/-   ##
==========================================
+ Coverage   73.23%   73.24%   +0.01%     
==========================================
  Files         573      573              
  Lines       71818    71854      +36     
==========================================
+ Hits        52595    52631      +36     
  Misses      19223    19223              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch was successfully deployed

1 active deployment
auto-approve — 90fbe848 Deployed Oct 20, 2026 by sagemaker-bot via wait-for-approval #1786
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant