fix: SMHP RLVR image selection and storm_rbs recipe cleanup#6079
Merged
mujtaba1747 merged 3 commits intoJul 22, 2026
Conversation
In _train_hyperpod, try get_hyperpod_training_image first (native SMHP image) and only fall back to SMTJ image with SM-TJ->SM-HP tag replacement if the SMHP image is not available. Previously the order was inverted.
amazeAmazing
changed the title
amazeAmazing
marked this pull request as ready for review
July 22, 2026 20:07
mujtaba1747
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Title: fix: SMHP RLVR image selection and storm_rbs recipe cleanup
Description:
The first two commits are from #6071 (authored by @ealynnh):
task_type: storm_rbsfrom RLVR/RFT recipes (only for Nova models) to fix service validation failurestask_typewhen customization technique is RLVR or RFTThe third commit addresses review feedback:
_train_hyperpodto tryget_hyperpod_training_imagefirst (native SMHP image), falling back to SMTJ→SMHP tag replacement only if neededTesting:
riv-rigcluster). Job submitted successfully and image resolved natively asSM-HP-RFT-TRAIN-V2-latestfrom the HyperPod template (no SMTJ fallback used). Did not have enough cluster capacity to run the job to completion but verified image resolution and recipe generation were correct.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.