Repository navigation
fix: sandbox Jinja2 rendering in standard template create path - #472
Open
mufaddal-rohawala wants to merge 1 commit into
Open
mufaddal-rohawala wants to merge 1 commit into
mufaddal-rohawala wants to merge 1 commit into
Conversation
`hyp create` rendered standard project template manifests (k8s.jinja / cfn_params.jinja) with a plain `jinja2.Template`. Rendering now uses `jinja2.sandbox.ImmutableSandboxedEnvironment` so template expressions cannot access unsafe Python attributes or callables. The recipe rendering path (recipe_utils._render_k8s_template) already used a sandboxed environment; this aligns the standard-template path in _create_standard_template with it. Adds tests asserting that a disallowed template expression is blocked and that benign templates still render.
mufaddal-rohawala
force-pushed
the
fix/ssti-sandboxed-jinja2-standard-templates
branch
from
October 22, 2026 18:28
68b0786 to
88ef335
Compare
mufaddal-rohawala
requested a deployment
to
manual-approval
October 22, 2026 18:33 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
hyp createrenders standard project template manifests (k8s.jinja/cfn_params.jinja) using a plainjinja2.Template. This change renders them inside a sandboxed Jinja2 environment instead, so template expressions cannot access unsafe Python attributes or callables.The recipe rendering path (
recipe_utils._render_k8s_template) already uses a sandboxed environment. This PR brings the standard-template path in_create_standard_templatein line with it.Change
src/sagemaker/hyperpod/cli/commands/init.py: render withjinja2.sandbox.ImmutableSandboxedEnvironmentinstead ofjinja2.Template.test/unit_tests/cli/test_init.py: tests asserting that a disallowed template expression is blocked and that benign templates still render.Testing