Skip to content
This repository was archived by the owner on Jun 22, 2026. It is now read-only.

docs(site): On sidecars, the depends_on attribute is not on image map (#5945) - #5950

Open
alquerci wants to merge 1 commit into
aws:mainlinefrom
alquerci:docs-site-on-sidecars-the-dependson-attributes-is-not-on-image-attribute-5945-
Open

alquerci wants to merge 1 commit into
aws:mainlinefrom
alquerci:docs-site-on-sidecars-the-dependson-attributes-is-not-on-image-attribute-5945-

Conversation

@alquerci

@alquerci alquerci commented Oct 7, 2024

Copy link
Copy Markdown

Changes

  • Remove sidecars.image.depends_on
  • Keep sidecars.depends_on
  • Keep image.depends_on

To not introduce duplication is creating an abstract common image template with same fields used on both concrete image Map.

Fixes #5945

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@alquerci
alquerci force-pushed the docs-site-on-sidecars-the-dependson-attributes-is-not-on-image-attribute-5945- branch from 339a733 to d174012 Compare October 7, 2024 19:05
@alquerci
alquerci requested review from a team and hkford as code owners October 7, 2024 19:05
@alquerci
alquerci requested review from efekarakus and removed request for a team October 7, 2024 19:05
@alquerci alquerci changed the title [WIP] docs(site): On sidecars, the depends_on attributes is not on image attribute (#5945) docs(site): On sidecars, the depends_on attributes is not on image attribute (#5945) Oct 7, 2024
@alquerci alquerci changed the title docs(site): On sidecars, the depends_on attributes is not on image attribute (#5945) docs(site): On sidecars, the depends_on attribute is not on image map (#5945) Oct 7, 2024
@alquerci
alquerci force-pushed the docs-site-on-sidecars-the-dependson-attributes-is-not-on-image-attribute-5945- branch from d174012 to 590e8e5 Compare October 7, 2024 19:16
@lucix-aws lucix-aws added do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. and removed do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. labels Apr 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading Doc: On sidecars, the depends_on attributes is not on image attribute

2 participants