Preserve millisecond precision during serialization - #3418
Open
richardwang1124 wants to merge 4 commits into
Open
Preserve millisecond precision during serialization#3418richardwang1124 wants to merge 4 commits into
richardwang1124 wants to merge 4 commits into
Conversation
sichanyoo
approved these changes
Sep 9, 2026
jterapin
approved these changes
Sep 9, 2026
jterapin
left a comment
jterapin
left a comment
Contributor
There was a problem hiding this comment.
LGTM - I would suggest that you want for the catapult pr build to finish before merging.
|
Detected 1 possible performance regressions:
|
sichanyoo
self-requested a review
September 9, 2026 21:56
sichanyoo
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ruby SDK currently truncates timestamps to whole seconds. This PR preserves millisecond precision on timestamps to align with other SDKs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the
CHANGELOG.mdfile (at corresponding gem). For the description entry, please make sure it lives in one line and starts withFeatureorIssuein the correct format.For generated code changes, please checkout below instructions first:
https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md
Thank you for your contribution!