(feat:prime/crac) Invoke the selected warm-up operation in the generated SdkWarmUpProvider#7159
Open
joviegas wants to merge 4 commits into
Open
Conversation
joviegas
force-pushed
the
joviegas/warmup_op_selector
branch
from
July 17, 2026 17:57
0a47adc to
6a8597c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The generated
SdkWarmUpProviderbuilt sync and async clients but made no request, so the marshalling, signing and unmarshalling paths stayed cold before the CRaC checkpoint.WarmUpOperationSelectoralready picks a safe operation per service but was not wired into codegen.Modifications
WarmUpProviderSpecselects the operation viaWarmUpOperationSelectorand emits a call to it inside each client's try-with-resources. The async path appends.join().warmup-provider-*.javato include the operation call.WarmUpProviderBindingTestincodegen-generated-classes-test. It drives the generatedProtocolRestJsonWarmUpProviderthroughwarmUpClient(SYNC),warmUpClient(ASYNC)andwarmUp(), and asserts the selected operation (AllTypes) runs. A globalOperationRecordingInterceptorobserves the calls made by the client the provider builds internally.Testing
License