Propagate error to active chunk subscriber in SplittingPublisher#6982
Open
davidh44 wants to merge 1 commit into
Open
Propagate error to active chunk subscriber in SplittingPublisher#6982davidh44 wants to merge 1 commit into
davidh44 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixed bug where
SplittingPublisher.onError()did not signal the activeSubAsyncRequestBody, causing its subscriber to hang until timeout instead of being notified immediatelyModifications
currentBody.error(t)inSplittingSubscriber.onError()error(Throwable)toSubAsyncRequestBodyinterface- Implement
error()inRetryableSubAsyncRequestBody- Override
error()inNonRetryableSubAsyncRequestBodyTesting
Added unit test
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License