Define list of modules to skip#6953
Conversation
| @@ -0,0 +1,19 @@ | |||
| architecture-tests | |||
There was a problem hiding this comment.
Wonder if we can write a script to include all modules under test folder so that we don't have to manually update this list
There was a problem hiding this comment.
if someone runs setup-new-module to create new test module, the list will get updated automatically
There was a problem hiding this comment.
we publish 3 modules under test folder to Maven (have been for a while now):
http-client-tests, ruleset-testing-core, test-utils
There was a problem hiding this comment.
Right, it still requires someone to remember to run setup-new-module though and we definitely missed it for ruleset-testing-core and test-utils. (http-client-tests being published may be intentional)
Nevertheless, we can allowlist those modules, right?
There was a problem hiding this comment.
Good point, updated to add allowlist and script to generate exclusion list
Motivation and Context
Create single source of truth for the list of modules to skip, for maven publishing and docs generation
buildspecs/release-to-maven.ymlandbuildspecs/release-javadoc.ymlwere recently removed from SDK reponew-module-verification.ymlchecks new test modules against MODULES_TO_SKIPscripts/setup-new-moduleupdates MODULES_TO_SKIPModifications
buildspecs/resources/test-modules-publish-allowlist.txt: 5 test modules intentionally published to Maven Central (bundle-logging-bridge-binding-test,http-client-tests,ruleset-testing-core,service-test-utils,test-utils), keeps existing behaviorbuildspecs/resources/generate-modules-to-skip.sh: script that generates module exclusion list at runtime, includes/testmodules.github/workflows/new-module-verification.yml: updated to inform whether a new test module is in the allowlist or will be auto-skippedscripts/setup-new-module:update_buildspecs()now prompts whether the new module should be published to Maven, and appends to the allowlist if yes.