Skip to content

Define list of modules to skip#6953

Open
davidh44 wants to merge 3 commits into
masterfrom
hdavidh/modules-to-skip
Open

Define list of modules to skip#6953
davidh44 wants to merge 3 commits into
masterfrom
hdavidh/modules-to-skip

Conversation

@davidh44
Copy link
Copy Markdown
Contributor

@davidh44 davidh44 commented May 11, 2026

Motivation and Context

Create single source of truth for the list of modules to skip, for maven publishing and docs generation

  • buildspecs/release-to-maven.yml and buildspecs/release-javadoc.yml were recently removed from SDK repo
    • These specs had hardcoded list MODULES_TO_SKIP
  • Github CI workflow new-module-verification.yml checks new test modules against MODULES_TO_SKIP
  • manually triggered scripts/setup-new-module updates MODULES_TO_SKIP

Modifications

  • buildspecs/resources/test-modules-publish-allowlist.txt: 5 test modules intentionally published to Maven Central (bundle-logging-bridge-binding-test, http-client-tests, ruleset-testing-core, service-test-utils, test-utils), keeps existing behavior
  • buildspecs/resources/generate-modules-to-skip.sh: script that generates module exclusion list at runtime, includes /test modules
  • .github/workflows/new-module-verification.yml: updated to inform whether a new test module is in the allowlist or will be auto-skipped
  • scripts/setup-new-module: update_buildspecs() now prompts whether the new module should be published to Maven, and appends to the allowlist if yes.

@davidh44 davidh44 requested a review from a team as a code owner May 11, 2026 20:17
@@ -0,0 +1,19 @@
architecture-tests
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we can write a script to include all modules under test folder so that we don't have to manually update this list

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if someone runs setup-new-module to create new test module, the list will get updated automatically

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we publish 3 modules under test folder to Maven (have been for a while now):
http-client-tests, ruleset-testing-core, test-utils

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it still requires someone to remember to run setup-new-module though and we definitely missed it for ruleset-testing-core and test-utils. (http-client-tests being published may be intentional)

Nevertheless, we can allowlist those modules, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, updated to add allowlist and script to generate exclusion list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants