Skip to content

Place generated files in CMAKE_BINARY_DIR.#3747

Open
teo-tsirpanis wants to merge 1 commit intoaws:mainfrom
teo-tsirpanis:binary-dir-autogen
Open

Place generated files in CMAKE_BINARY_DIR.#3747
teo-tsirpanis wants to merge 1 commit intoaws:mainfrom
teo-tsirpanis:binary-dir-autogen

Conversation

@teo-tsirpanis
Copy link
Contributor

Issue #, if available:

Description of changes:

Note

This is a reopening of #3459, which was closed for reasons unknown to me.

This PR updates the CMake project to place generated files in the binary directory, instead of the source directory. This follows best practices, and unblocks the vcpkg port to support configuring aws-sdk-cpp in parallel.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant