Skip to content

Cbor serde fix for empty input vs no input#3742

Merged
sbaluja merged 2 commits intomainfrom
cbor-serde-fix
Mar 10, 2026
Merged

Cbor serde fix for empty input vs no input#3742
sbaluja merged 2 commits intomainfrom
cbor-serde-fix

Conversation

@sbaluja
Copy link
Contributor

@sbaluja sbaluja commented Mar 9, 2026

Issue #, if available:

Description of changes:

  • Fix the serialized payloads for empty input vs no input
  • Remove unnecessary deserialization logic for results; we had unneccesary if statements looking for keys that would never exist, since they are not used for payloads (requestID)

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbaluja sbaluja merged commit 49ab4d1 into main Mar 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants