Fix JSON log parameter ordering

[Pybsama]

Issue #, if available:

Fixes #2468

Description of changes:

When the JSON logging path receives a custom ILogger state whose enumeration
order differs from {OriginalFormat}, order the callback arguments by message
template placeholder name instead of by state position.

The implementation:

• preserves missing placeholder slots and handles duplicate placeholder names;
• supports destructuring hints, alignment, format specifiers, escaped braces,
  and positional templates;
• keeps the existing fast path when state is already aligned, and uses the same
  1,024-entry soft cache cap as RuntimeSupport; and
• adds focused regressions for the ASP.NET Core hosting-log shape and the edge
  cases above, plus the required AutoVer patch change file.

Validation:

• dotnet test Libraries/test/Amazon.Lambda.Logging.AspNetCore.Tests/Amazon.Lambda.Logging.AspNetCore.Tests.csproj --framework net10.0 --configuration Debug (20 passed)
• dotnet test Libraries/test/Amazon.Lambda.Logging.AspNetCore.Tests/Amazon.Lambda.Logging.AspNetCore.Tests.csproj --framework net10.0 --configuration Release (20 passed)
• dotnet build Libraries/test/Amazon.Lambda.Logging.AspNetCore.Tests/Amazon.Lambda.Logging.AspNetCore.Tests.csproj --configuration Release --framework net8.0 (0 warnings, 0 errors)
• repeated the same checks after applying the commit cleanly to current master (fdb84c71)
• AutoVer change-file validation and git -c core.whitespace=cr-at-eol diff --check

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[madmox]

Reporter of #2468 here. The approach looks right, two practical notes:

• It's still marked as draft, so it won't reach the maintainers' review queue.
• It targets master. CONTRIBUTING.md does say master, but every recently merged PR here (release PRs included) targets dev; worth confirming before this stalls.

Also worth knowing: #2474 inserts a block immediately before the LambdaLogger.Log(...) call this PR modifies. The two are behaviorally independent, but whichever lands second will need a rebase.

[Pybsama]

Thanks for both notes. I checked them against the current repository state: #2545 retired the dev branch, so master is now the correct single-trunk target. I also applied this commit cleanly to current master (fdb84c71) and reran the focused suite: 20/20 tests in both Debug and Release on net10.0, plus a net8.0 Release build with 0 warnings and 0 errors.\n\n#2474 is still open. I confirmed that the changes are behaviorally independent but touch the same source/test regions, so whichever lands second will need a conflict resolution. If #2474 lands first, I will rebase this PR and add the combined category-prefix + reordered-parameters regression. Marking this ready for maintainer review now.

[Copilot]

Pull request overview

Fixes JSON structured logging by aligning custom ILogger state values with template placeholders.

Changes:

• Adds name-based parameter ordering and template parsing.
• Adds regression and edge-case tests.
• Adds an AutoVer patch entry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
LambdaILogger.cs	Implements parameter reordering and parsing.
LoggingTests.cs	Tests ordering and template edge cases.
.autover/changes/58593c38-0c20-4fee-993c-15ea9f1f49fb.json	Records the patch change.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[GarrettBeatty]

⚠️ This is an automated AI review for a first pass — please check for accuracy.

Reviewed the diff for #2506 (JSON log parameter ordering). 6 findings — no confirmed blockers. Two major items are open questions that depend on Amazon.Lambda.Core.LambdaLogger.Log, whose body isn't in this diff.

1. [major] LambdaILogger.cs · OrderParametersByMessageTemplate — Appending unconsumed state values and inserting null for missing placeholders could alter the observable JSON (extra/renamed fields, or a Missing: null field that didn't exist before). Can't confirm from the diff because LambdaLogger.Log's handling of surplus/null args isn't included. Can you confirm the downstream behavior — or whether reordering is the right layer vs. name-based assignment?

2. [major] LambdaILogger.cs — Duplicate-placeholder handling is asymmetric: when state has more same-name values than the template references, the extra is appended as an unnamed trailing value; when the template references more than state provides, the surplus becomes null. Neither direction has a test pinning the intended output.

3. [major] LambdaILogger.cs · UsesPositionalArguments — Strips a leading @ but not $ before int.TryParse, so {$0} is misclassified as non-positional and falls into the name-based path. No test covers $-prefixed positional templates.

4. [minor] LambdaILogger.cs · ParseTemplateProperties cache — if (Count < MAXSIZE) TryAdd(...) is check-then-act: under concurrency the cache can exceed 1024 (bounded overflow) and grow with high-cardinality templates. It's a process-lifetime static on a logging hot path.

5. [minor] LoggingTests.cs — The new facts assert the captured object[] parameter array + MessageTemplate, not serialized JSON. Correct seam for the reordering logic, but they don't prove observable output — relevant given finding #1.

6. [minor] .autover/changes/…json — Change type is Patch; if finding #1 confirms an observable output change, Minor would be more accurate.