chore: Use Github environment for CI secrets#1311
Open
lucasmcdonald3 wants to merge 9 commits intomasterfrom
Open
chore: Use Github environment for CI secrets#1311lucasmcdonald3 wants to merge 9 commits intomasterfrom
lucasmcdonald3 wants to merge 9 commits intomasterfrom
Conversation
Contributor
Author
|
Leaving a comment here -- I'm about to push a change to this branch that I expect will reduce the number of "temporarily deployed to ci" messages, and want an anchor to measure against. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
ciGithub environment to access secrets.Once this change is merged, I would validate it by opening a no-op PR from my fork.
This change has 2 assumptions: 1) Environment secrets are passed to fork-origin PRs (may need to add environment approver to
cienvironment); 2) The GHA workflow for a fork-origin PR will be authenticated as the main repo. If either of these are false, this change probably won't work. If that happens, we can revert the change.Pending team discussion, we may swap out the
aws-codebuild-run-buildaction with a bash script.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: