feat: add plugin interface (#371)#417
Open
zhongkechen wants to merge 1 commit into
Open
Conversation
zhongkechen
commented
Jun 4, 2026
| "opentelemetry-api>=1.20.0", | ||
| "opentelemetry-sdk>=1.20.0", | ||
| "opentelemetry-exporter-otlp", | ||
| "opentelemetry-propagator-aws-xray", |
Contributor
Author
There was a problem hiding this comment.
Not sure if these dependencies are required. If not, we can add them to the dependencies of example package
zhongkechen
force-pushed
the
otel3
branch
3 times, most recently
from
171fa60 to
875a7df
Compare
zhongkechen
commented
Jun 4, 2026
| ) | ||
| except subprocess.CalledProcessError: | ||
| logger.exception("Failed to install runtime dependencies") | ||
| return False |
Contributor
Author
There was a problem hiding this comment.
This would break local building of the package on MacOs if any of the dependencies rely on native extensions
Contributor
Author
There was a problem hiding this comment.
For now it seems OK. OTel doesn't have native extensions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fix: #386
Description of changes:
initial implementation of Otel plugin
Know issues
onOperationStartis called multiple times for Step operation if it's retriedBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.